jeanouii commented on PR #1497: URL: https://github.com/apache/activemq/pull/1497#issuecomment-3646464164
Personnally, I think it's a great PR and it demonstrates what we can do and the benefits. That being said, I can see 2 cases (similar to you) - Dev/pr: I'd only go for Ubuntu (1 version only) and JDK 17 (or 24). That's it. If we need to work with JDK 24 or 25, we can manually trigger it. - nightly: we can go wider and test the 3 JDK, and Ubuntu / Windows I'm fine adding MacOS, but 4 versions (for 3 JDK) sounds like a big cardinality for a very small coverage of the real life. I think probably less than 1% of production deployments are on MacOS. We can keep 1 or 2 versions of Windows, if we want, but multiplied by 3 JVM, that's already at least 5*3 = 15 builds+tests So overall, fully inline with you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
