mattrpav commented on PR #1616:
URL: https://github.com/apache/activemq/pull/1616#issuecomment-3760739762
The change to ActiveMQMessageConsumer needs some discussion, add'l unit
tests and perhaps some changes.
A couple things:
1. The map isn't cleared on close()
2. Consumer's are cached a lot so we need to make sure there aren't memory
leaks or issues with re-using consumers -- at the minimum we need some unit
testing to check for leaks of that new map.
3. If the map is keyed off of transactionId and only one transaction can be
opened per-consumer at a time -- why do we need a new class?
ref:
https://github.com/apache/activemq/pull/1610/commits/354e764ef9429e86cab4bda9625c1eef1ad81aee
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
