jeanouii commented on code in PR #1621:
URL: https://github.com/apache/activemq/pull/1621#discussion_r2709788683


##########
activemq-ra/src/test/java/org/apache/activemq/ra/ActiveMQConnectionFactoryTest.java:
##########
@@ -136,7 +136,7 @@ public void testXAResourceReconnect() throws Exception {
         try {
             final TransportConnector transportConnector = 
brokerService.getTransportConnectors().get(0);
 
-            String failoverUrl = 
String.format("failover:(%s)?maxReconnectAttempts=1", 
transportConnector.getConnectUri());
+            String failoverUrl = 
String.format("failover:(%s)?maxReconnectAttempts=10&initialReconnectDelay=100",
 transportConnector.getConnectUri());

Review Comment:
   It's not the same level I think.
   
   Doing it in the WaitFor in my opinion does not control the transport but how 
the test needs to wait to verify the reconnection succeeded.
   
   I've put it in the transport URL because I want to control how quickly the 
ActiveMQ client retries connection at the transport level.
   
   The second one is the one I wanted in this test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to