cshannon commented on code in PR #1628:
URL: https://github.com/apache/activemq/pull/1628#discussion_r2721505111
##########
activemq-unit-tests/src/test/java/org/apache/activemq/JMSConsumerTest.java:
##########
@@ -1066,4 +1070,13 @@ protected DestinationViewMBean
createView(ActiveMQDestination destination) throw
}
return (DestinationViewMBean)
broker.getManagementContext().newProxyInstance(name,
DestinationViewMBean.class, true);
}
+
+ private void assertNoAdditionalMessages(final AtomicInteger counter, final
int expected) throws Exception {
Review Comment:
> I prefer new code style and lambda for this usage. It's a bit more concise
and readable. But the code base does not massively use new language features,
so I wasn't sure it was good or not to start introducing myself.
Ah oops I missed this and saw you changed it so that is good.
Yeah much of the code is quite old so there is not a lot of modern stuff but
I think it's fine to introduce it. I figure it's not like we are going to go
through and do it all at once so it's fine to mix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
