gemmellr commented on code in PR #1532:
URL: https://github.com/apache/activemq/pull/1532#discussion_r2727821885
##########
pom.xml:
##########
@@ -1337,6 +1337,39 @@
</activation>
<build>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>enforce-maven</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <rules>
+ <requireMavenVersion>
+ <version>3.6.3</version>
+ </requireMavenVersion>
+ </rules>
+ </configuration>
+ </execution>
Review Comment:
Could similarly remove this maven version enforcement.
##########
pom.xml:
##########
@@ -1133,7 +1133,7 @@
<configuration>
<rules>
<requireMavenVersion>
- <version>3.0.5</version>
+ <version>3.6.3</version>
Review Comment:
The parent pom 37 now requires Maven 3.9 to build. Given 3.8.x is now
entirely out of support and new plugin releases are aimed at 3.9+, I'd say its
time to do the same (and have already done so in other projects). I'd also
defer to its enforcer definition (by removing this one entirely) at this point
to simplify the pom.
You could also get rid of the java version check below this one (but not the
other one in the release profile) and defer to the parents one. They have also
defined a new property in v37 to link all the java verison enforcement and
compiler settings together, though personally I prefer having the compiler
properties set in the components own pom and so am still setting them
regardless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
