jbonofre commented on code in PR #1649:
URL: https://github.com/apache/activemq/pull/1649#discussion_r2762861736
##########
activemq-unit-tests/src/test/java/org/apache/activemq/bugs/AMQ3529v2Test.java:
##########
@@ -200,21 +197,43 @@ public void run() {
for (ClientThread thread : threads) {
if (thread.error != null) {
- LOG.info("Close error on thread: " + thread, thread.error);
+ LOG.info("Close error on thread: {}", thread, thread.error);
}
}
- Thread[] remainThreads = new Thread[tg.activeCount()];
+ final Thread[] remainThreads = new Thread[tg.activeCount()];
tg.enumerate(remainThreads);
+ final List<Thread> transportThreads = new LinkedList<>();
for (final Thread t : remainThreads) {
- if (t != null && t.isAlive() && !t.isDaemon())
- assertTrue("Thread completes:" + t, Wait.waitFor(new
Wait.Condition() {
- @Override
- public boolean isSatisified() throws Exception {
- LOG.info("Remaining thread: " + t.toString());
- return !t.isAlive();
+ if (t == null || !t.isAlive() || t.isDaemon()) {
+ continue;
+ }
+ if (t.getName().startsWith("ActiveMQ Transport")) {
Review Comment:
Let me check if it's good enough for transport.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
