jeanouii commented on code in PR #1563:
URL: https://github.com/apache/activemq/pull/1563#discussion_r2769317160
##########
activemq-unit-tests/pom.xml:
##########
@@ -465,6 +465,18 @@
<exclude>**/ClientIdFilterDispatchPolicyTest.java</exclude>
<exclude>**/StartAndConcurrentStopBrokerTest.java</exclude>
<exclude>**/BlobTransferPolicyUriTest.java</exclude>
+
+ <!--
+ added when running under Java 21+, but it can't run as part of
normal tests
+ because Maven Surefire will use activemq-client/target/classes
instead of the MRJAR
+
+ This test needs to run as part of the integration test phase to
ensure it's using the packaged version
+ We use failsafe instead which is a better choice for integration
tests. See bellow the configuration.
+ -->
Review Comment:
I tried pushing this and I'll monitor the results to see if everything is ok
##########
activemq-unit-tests/pom.xml:
##########
@@ -507,6 +519,37 @@
</dependency>
</dependencies>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-failsafe-plugin</artifactId>
+ <version>3.5.2</version>
Review Comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
