jbonofre commented on code in PR #1659: URL: https://github.com/apache/activemq/pull/1659#discussion_r2792596044
########## assembly/src/docker/entrypoint.sh: ########## @@ -18,6 +18,8 @@ # limitations under the License. ################################################################################ +set -e Review Comment: Same comment here as in `Dockerfile`. ########## assembly/src/docker/Dockerfile: ########## @@ -32,14 +32,25 @@ ENV ACTIVEMQ_OPTS $ACTIVEMQ_OPTS_MEMORY -Djava.util.logging.config.file=logging. # activemq_dist can point to a directory or a tarball on the local system ARG activemq_dist=NOT_SET -COPY entrypoint.sh /usr/local/bin/entrypoint.sh +RUN groupadd -r activemq && useradd -r -g activemq -m activemq Review Comment: This is unrelated to this change/PR. We have another PR for non-root Docker run. Can you please remove `Dockerfile` and `entrypoint.sh` from this PR ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
