jeanouii commented on code in PR #1665:
URL: https://github.com/apache/activemq/pull/1665#discussion_r2794451805
##########
assembly/src/docker/entrypoint.sh:
##########
@@ -89,4 +91,15 @@ if [ -z "${ACTIVEMQ_OPTS}" ]; then
export ACTIVEMQ_OPTS
fi
-exec "$@"
+_term() {
+ echo "Received signal, stopping ActiveMQ..."
+ if [ -n "${child_pid:-}" ] && kill -0 "${child_pid}" 2>/dev/null; then
+ kill -TERM "${child_pid}" 2>/dev/null || true
+ fi
+}
+
+trap _term TERM INT
+
+"$@" &
+child_pid=$!
+wait "${child_pid}"
Review Comment:
exit missing right?
`exit $?`
##########
assembly/src/docker/entrypoint.sh:
##########
@@ -18,6 +18,8 @@
# limitations under the License.
################################################################################
+set -e
Review Comment:
Is it expected?
Any sed command bellow failing will fail silently. Not sure if you wanted
that or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
