mattrpav commented on code in PR #1682:
URL: https://github.com/apache/activemq/pull/1682#discussion_r2805166569
##########
.asf.yaml:
##########
@@ -32,16 +32,16 @@ github:
enabled_merge_buttons:
squash: true
- merge: false
- rebase: false
+ merge: true
+ rebase: true
Review Comment:
I think this is ok for now. As a community, we should make a goal by the end
of the year to sign all commits for software supply chain verification (which
means all merges would need to be done by CLI and not GH web page buttons)
##########
.asf.yaml:
##########
@@ -32,16 +32,16 @@ github:
enabled_merge_buttons:
squash: true
- merge: false
- rebase: false
+ merge: true
+ rebase: true
del_branch_on_merge: true
protected_branches:
main:
required_pull_request_reviews:
require_code_owner_reviews: false
- required_approving_review_count: 0
+ required_approving_review_count: 1
Review Comment:
+1 -- agree we should have this for supply chain traceability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
