mattrpav commented on code in PR #1710:
URL: https://github.com/apache/activemq/pull/1710#discussion_r2841771838
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -2624,6 +2624,12 @@ public ConnectionContext getAdminConnectionContext()
throws Exception {
protected void startManagementContext() throws Exception {
getManagementContext().setBrokerName(brokerName);
+ // Reuse the broker-level SSL context for JMX by default
+ // This avoids duplicating SSL config in activemq.xml while still
allowing an
+ // explicit managementContext sslContext to override when one is needed
+ if (getManagementContext().getSslContext() == null && getSslContext()
!= null) {
Review Comment:
There is a logic flaw here-- just b/c an SslContext exists on the broker,
does not mean the intent is to wire it to the management context.
If there is a fallback option, there most likely will need to be a config
flag on the managementContext to affirm that ssl should be enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
