jeanouii commented on code in PR #1728:
URL: https://github.com/apache/activemq/pull/1728#discussion_r2890723616
##########
activemq-client/src/main/java/org/apache/activemq/ActiveMQMessageProducer.java:
##########
@@ -168,6 +168,7 @@ public Destination getDestination() throws JMSException {
*/
@Override
public void close() throws JMSException {
+ ActiveMQSession.checkNotInCompletionListenerCallback("close");
Review Comment:
Yes, this is a step forward to implement the spec, but you are correct. This
is under the cover synchronous. This is purely spec related, and was a clear
design choice. We still have the `AsyncCallback` for high throughput.
That being said, I'm happy to push this as a first implementation attempt
and then think about a better way to implement this. Eager to hear your
thoughts and happy to give it a try. I'm too young for the moment :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
