cshannon commented on PR #1740:
URL: https://github.com/apache/activemq/pull/1740#issuecomment-4026135275

   > There's also a sendTimeout and possibly a connectTimeout in 
ActiveMQConnection. I recall adding sendTimeout a long time ago for similar 
reasons.
   
   Ah yeah, i see the 
[sendTimeout](https://github.com/apache/activemq/blob/6060f9bcd3b38c47225db1162260be6309590c44/activemq-client/src/main/java/org/apache/activemq/ActiveMQConnection.java#L160)
 already defined just below it, forgot about that. It is just used to pass to 
the producer (which makes sense it is only used on message sending).
   
   It would be nice to re-used a timeout but I think we likely need a new one 
that is more broad, ie `requestTimeout`. This new ew configuration would be 
more of a default for all requests that were not already covered by other 
specific cases such as connection, close, and send.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to