mattrpav commented on code in PR #1824:
URL: https://github.com/apache/activemq/pull/1824#discussion_r2976096124


##########
activemq-broker/src/main/java/org/apache/activemq/broker/jmx/DestinationView.java:
##########
@@ -136,6 +136,12 @@ public long getStoreMessageSize() {
         return messageStore != null ? 
messageStore.getMessageStoreStatistics().getMessageSize().getTotalSize() : 0;
     }
 
+    @Override
+    public long getMessagesCachedCount() {
+        return 
destination.getDestinationStatistics().getMessagesCached().getCount();
+    }
+
+    @Deprecated(forRemoval = true) // see: getMessagesCachedCount() instead. 
This method name is inconsistent

Review Comment:
   There is no 'getMessagesCached()' method. This PR adds the new field method 
with aligned naming
   
   ```
   public long getMessagesCachedCount();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to