jbonofre commented on code in PR #1852:
URL: https://github.com/apache/activemq/pull/1852#discussion_r3005772503
##########
activemq-unit-tests/src/test/java/org/apache/activemq/broker/policy/MessageInterceptorStrategyTest.java:
##########
@@ -207,7 +208,20 @@ public void testForceExpirationZeroOverrideDLQ() throws
Exception {
Message sendMessageP =
session.createTextMessage("expiration=zero-no-dlq-expiry");
producer.send(queue, sendMessageP);
- Thread.sleep(250l);
+ boolean reachedDlq = Wait.waitFor(new Wait.Condition() {
Review Comment:
`reachedDlq` result is unused.
If the condition times out (return `false` after 30s), the test will
silently proceed and likely fail.
I would add an assertion to prevent that:
```
assertTrue("Message did not reach DLQ in time", reachedDlq);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
