arnoudja commented on PR #1851: URL: https://github.com/apache/activemq/pull/1851#issuecomment-4165010468
@cshannon Thanks for the fix! One check, are you sure the call to beforeMarshall should be done after calling onSend and not before? As for the STOMP part: I've looked into it, and apparently we're not using STOMP for this but Ajax over HTTP. Sorry for the confusion. Looks like I can reproduce this on my machine now when using vm://. Looking at that scenario, should beforeMarshall also be called in ActiveMQSession.java in method send() just after (or before) the msg.onSend() line? That seems to fix it for me, but ofcourse I could be overlooking something. As for your restructuring idea, I think that'll be very useful but personally I wouldn't choose to put something like ActiveMQServerTextMessage above ActiveMQTextMessage. That would add yet another layer of complexity and feels like it's the wrong way around. My first idea would be to rename the current ActiveMQTextMessage, maybe to ActiveMQServerTextMesssage, make improvements in that one and add a new ActiveMQTextMessage class with the exact same interface as a wrapper around the renamed one. But I haven't checked whether such an approach would be feasible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
