mattrpav commented on code in PR #2019:
URL: https://github.com/apache/activemq/pull/2019#discussion_r3242982255
##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/TopicSubscription.java:
##########
@@ -55,6 +55,7 @@ public class TopicSubscription extends AbstractSubscription {
private int maximumPendingMessages = -1;
private MessageEvictionStrategy messageEvictionStrategy = new
OldestMessageEvictionStrategy();
private final AtomicInteger discarded = new AtomicInteger();
+ private boolean enableExpiry = true;
Review Comment:
This looks like a good addition to TopicSubscription so it may optimize
dispatching.
Nit: please rename 'enableExpiry' to 'expiryEnabled' so we get the
isExpiryEnabled() linguistics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
