cshannon commented on code in PR #2088:
URL: https://github.com/apache/activemq/pull/2088#discussion_r3375537712
##########
activemq-client/src/main/java/org/apache/activemq/ActiveMQConnectionMetaData.java:
##########
@@ -175,8 +179,10 @@ private static String getPlatformDetails() {
platformInfo.append(", ");
platformInfo.append(System.getProperty("os.arch"));
- details = platformInfo.toString();
- } catch (Throwable e) {
+ // truncate to the max allowed length if too long
+ details = platformInfo.length() > PLATFORM_DETAILS_MAX_LENGTH ?
Review Comment:
Yeah I think it's fine here, it's off by default and its now 512 and
shouldn't really be hit but we could improve it later if needed. This is more
of just a fail safe. I doubt anyone even turns this setting on to be honest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
