jbonofre opened a new pull request, #2123:
URL: https://github.com/apache/activemq/pull/2123
## Summary
`NetworkConnectorProcessor.configMatch` compared raw DTO values (still
holding `${...}` placeholders) against the live `NetworkConnector`, whose
attributes had already been resolved by Spring. A connector declared with
placeholders could therefore never be matched for removal or modification by
the `RuntimeConfigurationPlugin` — `modify` (implemented as remove + addNew)
left the original entry in place and added a duplicate, and `remove` was a
no-op.
The fix filters the DTO props through `placeHolderUtil` before comparing
them against the resolved candidate, mirroring what
`DefaultConfigurationProcessor.fromDto` already does for the values being
applied to live objects.
## Test plan
- [x] Added `SpringBeanTest#testRemovePropertyRefNetworkConnector` covering
two network connectors declared with `uri`, `userName`, and `password` all
driven by `${...}` placeholders, then removing one entry and asserting the live
broker drops to a single connector with the still-resolved attribute values.
Without the fix, the removal does not happen and the assertion times out.
- [ ] Existing `SpringBeanTest` / `NetworkConnectorTest` suites continue to
pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
