tabish121 commented on PR #2167: URL: https://github.com/apache/activemq/pull/2167#issuecomment-4859132874
> > The changes seem fine, unsure how well covered this is in the test suite though so not sure if you want to add any additional tests for these conditions. > > I didn't add anything because I didn't think it would be very easy to fake a negative value for AMQP with the client, unless you have any suggestions. I suppose just doing some mocking or calling the validation directly would be the only option otherwise. Why would you need a client when AmqpWireFormat > > The changes seem fine, unsure how well covered this is in the test suite though so not sure if you want to add any additional tests for these conditions. > > I didn't add anything because I didn't think it would be very easy to fake a negative value for AMQP with the client, unless you have any suggestions. I suppose just doing some mocking or calling the validation directly would be the only option otherwise. I don't think you'd need a client or proton to test it since the NIO bit reads from a DataInput and the AmqpFrameParser reads from a ByteBuffer so you can just simulate the values -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
