cshannon commented on PR #2225: URL: https://github.com/apache/activemq/pull/2225#issuecomment-5003402314
@mattrpav - Thanks for getting this started, I'll just make a couple points here. This is going to be a lot of work so this isn't really suited for a single PR. The work here is going to need to be divided up and there will be some back and forth as we go. What I would recommend is the strategy we did in Apache Accumulo when we first started working on a major refactor of the project to make it more "elastic", and that is create a long running feature branch that we create PRs against. One reason for the separate branch is we keep main clean until we are happy with the work. This is such a big feature that we might have to redo things and refactor a few times until we are happy with it. It's not possible to do it all in one big commit but it also doesn't make sense to merge work that is half done. During the initial work things are going to break, it's just a big refactor and that is fine becuase it will be isolated outside of main. The other reason is we can avoid the extra work for the transition stuff. In fact, your PR directly illustrates this because you had to create classes like SharedTopicBrokerService which are throw away and I'd rather avoid. If we keep it separate we don't need to do that. We can just update BrokerService directly as there is no need to worry about isolated testing because the feature branch is doing the isolation for us. After creating the branch we need to periodically merge the main branch into it (note I said merge, we don't want to rebase) to keep things up to date. Once we thing it's good we can create a PR and merge the feature branch back into main and preserve the commit history. So the basic flow would be: 1. Create a feature branch for shared sub support in the activemq repo 2. periodically merge main into it to keep it up to date and resolve conflicts 3. create PRs against the feature branch 4. Merge the feature branch back into main when we are done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
