cshannon commented on PR #2233: URL: https://github.com/apache/activemq/pull/2233#issuecomment-5022522998
> @cshannon this is a super awesome feature! First glance, I think it should include some metrics for tracking time, pages and/or file size compacted. > > I’m happy to help add those Metrics for pages/size are useful but time would not be for truncation. Time would be useful for when defrag is implemented but for truncation it's nearly instant time so there's nothing to really measure. Also, something to discuss is if we enable this by default. For something like defragmentation we could leave it off by default, but for a simple truncation like this PR is doing I think having it on by default could make sense. We would need to decide on default parameter thresholds though. For now I picked .1 for `minFreePageCompactionRatio` (leave 10% free pages relative to the current size after compaction) and .3 for `maxFreePageCompactionRatio` (don't start trying to compact until there's at least 30% pages that are free relative to the current size) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
