cshannon commented on PR #2206: URL: https://github.com/apache/activemq/pull/2206#issuecomment-5036721330
> > > This is a critical component, I think having a unit test to confirm all our shutdown handlers and thread handling is correct for the JVM to shutdown when this occurs. Especially to confirm things like daemon v non-daemon threads, etc. > > > > > > I don't really know what you mean? the whole JVM will shut down...what is there to check? it's just going to kill the JVM including all threads regardless. I also don't know how you expect to test it because the JVM would die > > The JVM won't exit if there is a non-daemon thread running. ActiveMQ sets daemon = true in several areas. > > ref: https://github.com/search?q=repo%3Aapache%2Factivemq+setDaemon&type=code System.exit(1) kills the JVM, it doesn't matter what threads are running or not. It just halts the JVM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
