colinwerner commented on code in PR #2052: URL: https://github.com/apache/activemq/pull/2052#discussion_r3692226950
########## assembly/src/docker/Dockerfile: ########## @@ -16,7 +16,7 @@ # limitations under the License. ################################################################################ -ARG java_version=17 +ARG java_version=21 Review Comment: @jbonofre you beat me to it with #2257, so I rebased and dropped my Dockerfile change. One thing I noticed and don't quite yet understand is that docker-java-version in the root pom is still 17, and the docker and docker-deploy profiles pass it as a build arg, which overrides the ARG default. So `mvn -Pdocker` builds a 17 image while docker build gives 25. I set the property to 25 here so the two agree. I verified it both ways locally; the default build pulls 25-jre, and the image comes out Temurin-25.0.3+9, and forcing `-Ddocker-java-version=17` pulls 17-jre. Broker starts up fine on 25. The 6.3.0 image on docker hub is already 25, though, so I am guessing the release was built with `-Ddocker-java-version=25` passed in? Can you confirm? If so, this would just remove the need for the override. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
