cshannon commented on code in PR #2272:
URL: https://github.com/apache/activemq/pull/2272#discussion_r3713068507


##########
activemq-client/src/main/java/org/apache/activemq/ActiveMQMessageProducerSupport.java:
##########
@@ -56,7 +56,9 @@ public ActiveMQMessageProducerSupport(ActiveMQSession 
session) {
      */
     @Override
     public void setDeliveryDelay(long deliveryDelay) throws JMSException {
-        throw new UnsupportedOperationException("setDeliveryDelay() is not 
supported");
+        if (deliveryDelay != 0) {

Review Comment:
   My preference would be to leave the setter alone. I don't think we should 
allow using it as it's not supported, the getter can just return 0 for now, 
meaning there's just no delay.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to