cshannon commented on code in PR #2399: URL: https://github.com/apache/activemq/pull/2399#discussion_r3716657059
########## activemq-broker/src/test/java/org/apache/activemq/network/FutureBrokerInfoTimeoutTest.java: ########## @@ -0,0 +1,160 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.activemq.network; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertTrue; + +import java.util.concurrent.TimeUnit; +import java.util.concurrent.TimeoutException; +import java.util.concurrent.atomic.AtomicBoolean; +import java.util.concurrent.atomic.AtomicLong; +import java.util.concurrent.atomic.AtomicReference; + +import org.apache.activemq.command.BrokerInfo; +import org.apache.activemq.network.DemandForwardingBridgeSupport.FutureBrokerInfo; +import org.junit.Test; + +/** + * Verifies that {@link DemandForwardingBridgeSupport.FutureBrokerInfo} + * honors the timeout passed to {@link FutureBrokerInfo#get(long, TimeUnit)}. + * + * The timed get loop must exit when EITHER the bridge is disposed OR the + * deadline expires. A faulty OR condition on the two checks keeps the loop + * alive as long as the bridge is not disposed, ignoring the caller's timeout + * entirely and parking bridge start threads indefinitely when the peer never + * delivers its BrokerInfo. + */ +public class FutureBrokerInfoTimeoutTest { + + /** + * No info, not disposed: get(200ms) must throw TimeoutException promptly + * rather than blocking until disposal. + */ + @Test(timeout = 10000) + public void testGetTimedThrowsTimeoutExceptionWithinTimeout() throws Exception { + AtomicBoolean disposed = new AtomicBoolean(false); + FutureBrokerInfo future = new FutureBrokerInfo(null, disposed); + + AtomicBoolean timedOut = new AtomicBoolean(false); + AtomicLong elapsed = new AtomicLong(-1); + + Thread t = new Thread(() -> { Review Comment: also it might be worth wrapping the assertion in a try/finally just in case it get stuck: ```java try { assertTrue("get(200ms) should have returned within 3s but is still blocked " + "- the timeout is being ignored", executor.awaitTermination(3, TimeUnit.SECONDS)); } finally { executor.shutdownNow(); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
