mattrpav commented on code in PR #2475:
URL: https://github.com/apache/activemq/pull/2475#discussion_r3823172910
##########
activemq-broker/src/main/java/org/apache/activemq/network/DemandForwardingBridgeSupport.java:
##########
@@ -1328,8 +1328,13 @@ public void onCompletion(FutureResponse future) {
} else if (command.isBrokerInfo()) {
futureLocalBrokerInfo.set((BrokerInfo) command);
} else if (command.isShutdownInfo()) {
- LOG.info("{} Shutting down {}",
configuration.getBrokerName(), configuration.getName());
- stop();
+ if (brokerService.isStopping() ||
brokerService.isStopped()) {
Review Comment:
See: the serviceRemoteCommand handling. There, it also eventually calls to
fireBridgeFailed(). This change is bringing the serviceLocalCommand to parity
with the serviceRemoteCommand. No new behavior introduced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
