mattrpav commented on code in PR #1484:
URL: https://github.com/apache/activemq/pull/1484#discussion_r3904819061
##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/RegionBroker.java:
##########
@@ -936,6 +936,13 @@ protected void purgeInactiveDestinations() {
context.setBroker(this);
for (Destination dest : list) {
+ // Re-verify eligibility right before removal - a message
can arrive
+ // (e.g. from an anonymous producer, which does not hold
the purge
+ // lock) between the mark loop above and this removal loop.
+ if (!dest.canGC()) {
Review Comment:
Agreed. Removed in second commit with review feedback changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
