hai-ben opened a new pull request, #2517: URL: https://github.com/apache/activemq/pull/2517
Increment in the check loop happens before the check, causing an error. Additionally this code is [practically duplicated here](https://github.com/apache/activemq/blob/main/activemq-mqtt/src/main/java/org/apache/activemq/transport/mqtt/MQTTCodec.java#L165-L167C18). That code has it correct, but it looks tricky to abstract into a shared class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
