mattrpav commented on PR #2590: URL: https://github.com/apache/activemq/pull/2590#issuecomment-5779470566
@cshannon the accounting is incorrect. If the write fails, the queue size and expiry count are incorrect when this occurs. This change addresses the accounting by moving the expiredCount to after the write is successful, and by allowing for retrying of the expiry, the queue size metric won't be incorrect -- queueSize > 0 when there are no messages to be processed. The IOException is already being caught today. The new log may be better phrased to say 'expiry _may_ be retried'. IOExceptionHandler decision to move broker into inactive mode is orthogonal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
