mattrpav commented on code in PR #2585:
URL: https://github.com/apache/activemq/pull/2585#discussion_r4073551013
##########
activemq-broker/src/main/java/org/apache/activemq/transaction/Transaction.java:
##########
@@ -134,24 +134,59 @@ protected void fireBeforeCommit() throws Exception {
}
protected void fireAfterCommit() throws Exception {
+ // The transaction outcome is already durable when afterCommit runs,
so a
+ // failing synchronization must not prevent the remaining ones from
+ // executing (e.g. the destination synchronization that maintains the
+ // destination statistics) - run them all and rethrow the first
failure.
+ Throwable firstException = null;
synchronized(synchronizations) {
for (Iterator<Synchronization> iter = synchronizations.iterator();
iter.hasNext();) {
Synchronization s = iter.next();
- s.afterCommit();
+ try {
+ s.afterCommit();
+ } catch (Throwable t) {
Review Comment:
I don't like catching Throwable either, but leaving other synchronizations
hanging out in space leads to incorrect accounting and preventing them from
completing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
