mattrpav commented on code in PR #2634:
URL: https://github.com/apache/activemq/pull/2634#discussion_r4195588134
##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/Topic.java:
##########
@@ -719,11 +719,14 @@ public Message[] browse() {
public void doBrowse(final List<Message> browseList, final int max) {
try {
if (topicStore != null) {
+ // a JDBC ack moves the last acked id of the subscription, so
expiring a browsed
+ // message would also ack the non-expired messages before it
+ final boolean expireFromStore = topicStore.getType() ==
StoreType.JDBC;
Review Comment:
This breaks modularity. There shouldn't be a check for an underlying store
type and a subsequent change in logic. If there is a problem with the JDBC
ack'n with browsed messages, we should fix that in the JDBC layer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
