mattrpav commented on code in PR #2461:
URL: https://github.com/apache/activemq/pull/2461#discussion_r4250150185
##########
activemq-broker/src/main/java/org/apache/activemq/broker/TransportConnection.java:
##########
@@ -1480,9 +1481,26 @@ public Response processBrokerInfo(BrokerInfo info)
throws IOException {
setDuplexNetworkConnectorId(duplexNetworkConnectorId);
}
+ // A connection that authenticated as an ordinary client and only now
declares
+ // itself a network connection must have been permitted to do so.
Bridges normally
+ // send BrokerInfo first, in which case authentication already saw the
flag and
+ // there are no connection states here yet.
+ var connectionStates = listConnectionStates();
Review Comment:
Good catch. The original intent was authz only the network conn info part.
Since the feature expanded to allow authz on a number of connection related
infos, the place you pointed out is not just subjectively better -- but
required for those other authz points to be functional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
