cshannon commented on code in PR #2680:
URL: https://github.com/apache/activemq/pull/2680#discussion_r4303407546
##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/AbstractRegion.java:
##########
@@ -407,12 +407,25 @@ public Subscription addConsumer(ConnectionContext
context, ConsumerInfo info) th
try {
dest.addSubscription(context, sub);
removeList.add(dest);
- } catch (SecurityException e){
+ } catch (Exception e){
if (sub.isWildcard()) {
- LOG.debug("Subscription denied for {} to destination
{}: {}",
+ LOG.debug("Subscription {} for {} to destination {}:
{}",
+ e instanceof SecurityException ? "denied" :
"failed",
sub, dest.getActiveMQDestination(),
e.getMessage());
} else {
- // remove partial subscriptions
+ // Clean up current dest that failed in case it was
partially added
+ // to the destination tracking, and failed after. This
might be in a
+ // bad state and my not need to be cleaned up at all,
so just log as debug
Review Comment:
good catch, fixed in latest push
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
