mwashburn2 opened a new issue, #2696:
URL: https://github.com/apache/activemq/issues/2696

   `TcpTransport.initialiseSocket` only applies `socketBufferSize` when it is 
positive, and otherwise logs a WARN:
   
   ```
   Socket buffer size was set to 0; Skipping this setting as the size must be a 
positive number.
   ```
   
   Setting `socketBufferSize=0` is a useful, deliberate configuration: by not 
calling `setSendBufferSize`/`setReceiveBufferSize`, the OS defaults apply and 
Linux `tcp_wmem`/`tcp_rmem` auto-tuning stays enabled (an explicit 
`SO_SNDBUF`/`SO_RCVBUF` disables it). Today this logs a misleading warning on 
every connection.
   
   Proposal:
   - `socketBufferSize > 0`: unchanged, set both buffers.
   - `socketBufferSize == 0`: leave both buffers unset (OS default / kernel 
auto-tuning), log nothing.
   - `socketBufferSize < 0`: invalid; ignore it and log at ERROR.
   
   Also document `0` on the TCP transport reference page.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to