sharanggupta opened a new pull request, #2742: URL: https://github.com/apache/activemq/pull/2742
Fixes #2741. `String.toUpperCase()`/`toLowerCase()` without a `Locale` follow the JVM default locale, so under `tr-TR` the documented lowercase KahaDB values (`periodic`, `commit`, `entire_journal_async`, `sparse_file`) fail `Enum.valueOf` with `PERİODİC` etc. and the broker does not start; the AMQP `charset=iso-8859-1` parameter becomes `İSO-8859-1` and the message is rejected; and `engineType="innodb"` no longer matches `INNODB` in the MySQL adapter. - `MessageDatabase`: the four `Enum.valueOf(x.trim().toUpperCase())` sites now use `Locale.ENGLISH` (the convention `IntrospectionSupport` already follows). - `AmqpContentTypeSupport`: type, subtype and charset folding use `Locale.ENGLISH`. - `MySqlJDBCAdapter`: engine type comparison uses `Locale.ENGLISH`. - Tests: `MessageDatabaseTest#testStringSettingsAreParsedRegardlessOfDefaultLocale` and `AmqpContentTypeSupportTest#testParseContentTypeCharsetRegardlessOfDefaultLocale` set a `tr-TR` default locale (restored in `finally`); both fail before the fix and pass after. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
