jeanouii commented on PR #2756: URL: https://github.com/apache/activemq/pull/2756#issuecomment-6469585148
Looks good and it's a great fix. Because this will prevent previous clients without certificat to connect with needClientAuth because it was not honored previously, we need to make it clear in the release notes I think. In the test, the result of the createConnection() should be assigned to the connection of the parent maybe so the tearDown() can close it. Nothing important or critical. Is there a negative test that basically asserts that a client without a valid certificate is now rejected? Is there any back port you plan to do on other branches? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
