jeanouii commented on code in PR #2606:
URL: https://github.com/apache/activemq/pull/2606#discussion_r4602960676
##########
activemq-client/src/main/java/org/apache/activemq/ActiveMQConnectionFactory.java:
##########
@@ -398,6 +400,15 @@ protected ActiveMQConnection
createActiveMQConnection(String userName, String pa
connection.setDefaultClientID(clientID);
}
+ // Jakarta Messaging expects createConnection/createContext to
authenticate
+ // the caller immediately (JMSSecurityException on bad
credentials). ActiveMQ
+ // historically defers the ConnectionInfo exchange until first
use, so the
+ // eager check is only performed under strictCompliance, and it
uses a probe
+ // so the connection's own identity stays unset for a later
setClientID().
+ if (isStrictCompliance()) {
+ connection.authenticate();
Review Comment:
Does it mean that under strict compliance, we open/close a second connection?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact