jcamachor commented on a change in pull request #583: Hive 21537 Scalar query 
rewrite could be improved to not generate an extra join if subquery is 
guaranteed to produce atmost one row
URL: https://github.com/apache/hive/pull/583#discussion_r270568468
 
 

 ##########
 File path: 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSubQueryRemoveRule.java
 ##########
 @@ -105,11 +105,9 @@ public void onMatch(RelOptRuleCall call) {
       SubqueryConf subqueryConfig = filter.getCluster().getPlanner().
           getContext().unwrap(SubqueryConf.class);
       boolean isCorrScalarQuery = 
subqueryConfig.getCorrScalarRexSQWithAgg().contains(e.rel);
-      boolean hasNoWindowingAndNoGby =
-          subqueryConfig.getScalarAggWithoutGbyWindowing().contains(e.rel);
 
 Review comment:
   With this patch ```getScalarAggWithoutGbyWindowing``` does not seem to be 
used anymore. If that is the case, we should remove it from the config, from 
the context, and get rid of it in ```CalcitePlanner``` too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to