ashutosh-bapat commented on a change in pull request #579: HIVE-21109 : Support stats replication for ACID tables. URL: https://github.com/apache/hive/pull/579#discussion_r270794735
########## File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestStatsReplicationScenarios.java ########## @@ -301,12 +338,106 @@ private String dumpLoadVerify(List<String> tableNames, String lastReplicationId, return dumpTuple.lastReplicationId; } + /** + * Run a bootstrap that will fail. + * @param tuple the location of bootstrap dump + */ + private void failBootstrapLoad(WarehouseInstance.Tuple tuple, int failAfterNumTables) throws Throwable { + // fail setting ckpt directory property for the second table so that we test the case when + // bootstrap load fails after some but not all tables are loaded. + BehaviourInjection<CallerArguments, Boolean> callerVerifier + = new BehaviourInjection<CallerArguments, Boolean>() { + int cntTables = 0; + @Nullable + @Override + public Boolean apply(@Nullable CallerArguments args) { + cntTables++; + if (args.dbName.equalsIgnoreCase(replicatedDbName) && cntTables > failAfterNumTables) { + injectionPathCalled = true; + LOG.warn("Verifier - DB : " + args.dbName + " TABLE : " + args.tblName); + return false; + } + return true; + } + }; + + InjectableBehaviourObjectStore.setAlterTableModifier(callerVerifier); + try { + replica.loadFailure(replicatedDbName, tuple.dumpLocation); + callerVerifier.assertInjectionsPerformed(true, false); + } finally { + InjectableBehaviourObjectStore.resetAlterTableModifier(); + } Review comment: I don't think we need to be really hard and fast about the exact number of tables loaded. All we are testing is whether there was a failure and the retry loaded the stats successfully. Current set of checks is enough for that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org