jdere commented on a change in pull request #582: Hive 21386: Extend the fetch 
task enhancement done in HIVE-21279 to make it work with query result cache
URL: https://github.com/apache/hive/pull/582#discussion_r271030420
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
 ##########
 @@ -7175,6 +7176,23 @@ private ExprNodeDesc getNotNullConstraintExpr(Table 
targetTable, Operator input,
     return currUDF;
   }
 
+  private Path getDestinationFilePath(final String destinationFile, boolean 
isMmTable)
+      throws SemanticException {
+    if (this.isResultsCacheEnabled() && this.queryTypeCanUseCache()) {
+      assert (!isMmTable);
 
 Review comment:
   Is isMmTable necessarily false when this method is called below?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to