vineetgarg02 commented on a change in pull request #582: Hive 21386: Extend the 
fetch task enhancement done in HIVE-21279 to make it work with query result 
cache
URL: https://github.com/apache/hive/pull/582#discussion_r271070841
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
 ##########
 @@ -7175,6 +7176,23 @@ private ExprNodeDesc getNotNullConstraintExpr(Table 
targetTable, Operator input,
     return currUDF;
   }
 
+  private Path getDestinationFilePath(final String destinationFile, boolean 
isMmTable)
+      throws SemanticException {
+    if (this.isResultsCacheEnabled() && this.queryTypeCanUseCache()) {
+      assert (!isMmTable);
 
 Review comment:
   From what I understood this will either be called for SELECT queries or 
CTAS. Result cached is disabled for CTAS. This is kind of indirect way of 
asserting that if result cache is enabled it is SELECT and not CTAS.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to