b-slim commented on a change in pull request #626: [HIVE-21686] ensure that
memory allocator does not evict using brute …
URL: https://github.com/apache/hive/pull/626#discussion_r283820576
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java
##########
@@ -294,25 +385,18 @@ public void allocateMultiple(MemoryBuffer[] dest, int
size, BufferObjectFactory
// allocator thread (or threads per arena).
// The 2nd one is probably much simpler and will allow us to get rid of a
lot of sync code.
// But for now we will just retry. We will evict more each time.
- int attempt = 0;
+ int discardsAttempt = 0;
boolean isFailed = false;
int memoryForceReleased = 0;
try {
int discardFailed = 0;
while (true) {
// Try to split bigger blocks.
- int startArenaIx = (int)((threadId + attempt) % arenaCount);
+ startArenaIx = (int)((threadId + discardsAttempt) % arenaCount);
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
