vineetgarg02 commented on a change in pull request #630: HIVE-21365
URL: https://github.com/apache/hive/pull/630#discussion_r284927275
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateJoinTransposeRule.java
##########
@@ -63,20 +66,16 @@
*/
public class HiveAggregateJoinTransposeRule extends AggregateJoinTransposeRule
{
- /** Extended instance of the rule that can push down aggregate functions. */
- public static final HiveAggregateJoinTransposeRule INSTANCE =
- new HiveAggregateJoinTransposeRule(HiveAggregate.class, HiveJoin.class,
- HiveRelFactories.HIVE_BUILDER, true);
+ private static final Logger LOG =
LoggerFactory.getLogger(HiveAggregateJoinTransposeRule.class);
private final boolean allowFunctions;
+ private final AtomicInteger noColsMissingStats;
/** Creates an AggregateJoinTransposeRule that may push down functions. */
- private HiveAggregateJoinTransposeRule(Class<? extends Aggregate>
aggregateClass,
- Class<? extends Join> joinClass,
- RelBuilderFactory relBuilderFactory,
- boolean allowFunctions) {
- super(aggregateClass, joinClass, relBuilderFactory, true);
- this.allowFunctions = allowFunctions;
+ public HiveAggregateJoinTransposeRule(AtomicInteger noColsMissingStats) {
Review comment:
With this change instead of having a static instance now we will create a
different instance each time this rule needs to be executed. What is the reason
to change this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
