b-slim commented on a change in pull request #634: HIVE-21732: Configurable
injection of latency for LLAP task execution
URL: https://github.com/apache/hive/pull/634#discussion_r285159802
##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -627,6 +627,14 @@ private static void populateLlapDaemonVarsSet(Set<String>
llapDaemonVarsSetLocal
"internal usage only, used only in test mode. If set false, the
operation logs, and the " +
"operation log directory will not be removed, so they can be found
after the test runs."),
+ HIVE_TEST_LOAD_ENABLED("hive.test.load.enabled", false,
Review comment:
Can you please check how this new config is different form
`org.apache.hadoop.hive.conf.HiveConf.ConfVars#HIVE_IN_TEST` ? In my opinion we
should keep only one if possible. also in your code having an empty hostname
filed or load utilization = 0 should be enough to turn this on and off thus i
recommend removing this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
