odraese commented on a change in pull request #634: HIVE-21732: Configurable
injection of latency for LLAP task execution
URL: https://github.com/apache/hive/pull/634#discussion_r285677877
##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -627,6 +627,15 @@ private static void populateLlapDaemonVarsSet(Set<String>
llapDaemonVarsSetLocal
"internal usage only, used only in test mode. If set false, the
operation logs, and the " +
"operation log directory will not be removed, so they can be found
after the test runs."),
+ HIVE_TEST_LOAD_HOSTNAMES("hive.test.load.hostnames", "",
+ "Specify host names for load testing. (e.g., \"host1,host2,host3\").
Leave it empty if no " +
+ "load generation is needed (eg. for production)."),
+ HIVE_TEST_LOAD_INTERVAL("hive.test.load.interval", "10ms", new
TimeValidator(TimeUnit.MILLISECONDS),
+ "The interval length used for load generation in milliseconds"),
Review comment:
I think, this description could add a little detail here. What happens per
interval? Is this 10ms of load and then (how long) no load. Is this a complete
iterations and does a factor of 0.2 mean that 2ms are LOAD and 8ms are idle?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
