odraese commented on a change in pull request #633: HIVE-21740: Collect LLAP
execution latency metrics
URL: https://github.com/apache/hive/pull/633#discussion_r285701292
##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -4438,6 +4438,10 @@ private static void
populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
LLAP_COLLECT_LOCK_METRICS("hive.llap.lockmetrics.collect", false,
"Whether lock metrics (wait times, counts) are collected for LLAP "
+ "related locks"),
+ LLAP_DECAY_METRIC_SIZE("hive.llap.metrics.decay.size", 1028,
+ "The number of samples to keep in the sampling reservoir"),
+ LLAP_DECAY_METRIC_ALPHA("hive.llap.metrics.decay.alpha", 0.015f,
+ "Exponential decay factor; higher is more biased towards newer
values"),
Review comment:
Listing valid ranges for alpha would help.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
