odraese opened a new pull request #643: Hive 21785: Add task queue/runtime stats per LLAP daemon to output URL: https://github.com/apache/hive/pull/643 In addition the the new counters (described in the JIRA here https://issues.apache.org/jira/browse/HIVE-21785), I also fixed a bug in TezExecutorService, which had the task time being counted as "running" even if a task was rejected for execution. Following (original) code first sets the counter status to running (from here on we can't go backwards and all elapsing time is considered to be running time). But the ```executorService.submit(task)``` might throw a ```RejectionException``` if the executors are all used up. We then loop back and either kill a preemptable task or wait until an executor finishes its task execution. All this waiting time was accounted as "running" for the task that failed to be scheduled. ``` TaskRunnerCallable task = taskWrapper.getTaskRunnerCallable(); task.setWmCountersRunning(); ListenableFuture<TaskRunner2Result> future = executorService.submit(task); ``` I simply moved the ```setWmCountersRunning``` behind the submit....
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
