ashutosh-bapat commented on a change in pull request #642: HIVE-21776 :
Replication fails to replicate a UDF with jar on HDFS during incremental
URL: https://github.com/apache/hive/pull/642#discussion_r287213878
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java
##########
@@ -356,6 +356,9 @@ public static FileInfo getFileInfo(Path src, String
checksumString, String srcCM
// Currently using fileuri#checksum#cmrooturi#subdirs as the format
public static String encodeFileUri(String fileUriStr, String fileChecksum,
String encodedSubDir)
throws IOException {
+ if (instance == null) {
Review comment:
assert may not trigger in production and we won't catch the problem in REPL
DUMP itself. The problem will be seen only in REPL LOAD, and that too with no
clue as to what went wrong. So, it's better to have an exception.
IllegalStateException is better. Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
