odraese commented on a change in pull request #648: HIVE-21783: Accept Hive
connections from the same domain without authentication.
URL: https://github.com/apache/hive/pull/648#discussion_r288187467
##########
File path: service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java
##########
@@ -123,7 +123,7 @@ public HiveAuthFactory(HiveConf conf) throws
TTransportException {
return saslProps;
}
- public TTransportFactory getAuthTransFactory() throws LoginException {
+ public TTransportFactory getAuthTransFactory(String hiveHost) throws
LoginException {
Review comment:
hiveHost is the host name of HS2. We could either automatically detect this
or we could rename this to "validDomain" as we really just specify here, what
we use to check against with incoming requests.....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
